Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monetary value and price #1902 #1915

Merged
merged 16 commits into from
Sep 20, 2024
Merged

monetary value and price #1902 #1915

merged 16 commits into from
Sep 20, 2024
+78 −10

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Sep 6, 2024 •
edited
Loading

Summary of the discussion

From #1902 and #1875

Type of change (CHANGELOG.md)

Add

  • add monetary price as quality

Update

  • relabel monetary price as monetary value
  • add axioms to subclasses of monetary value (oeo-shared-axioms)

Workflow checklist

Automation

Closes #1902

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-social changes the oeo-social module label Sep 6, 2024
@stap-m stap-m self-assigned this Sep 19, 2024
@stap-m stap-m marked this pull request as ready for review September 19, 2024 12:59
@l-emele l-emele added this to the oeo-release-2.5.0 milestone Sep 20, 2024
@stap-m stap-m requested a review from l-emele September 20, 2024 09:05
l-emele
l-emele approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks for implementing.

@stap-m stap-m merged commit fb7fd95 into dev Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-emele l-emele l-emele approved these changes

@nelekoehler nelekoehler Awaiting requested review from nelekoehler

Assignees

@stap-m stap-m

Labels
oeo-shared-axioms oeo-social changes the oeo-social module
Projects
Issues
Status: Done
Milestone
oeo-release-2.5.0
Development

Successfully merging this pull request may close these issues.

Restructuring quantities and quantity values: Monetary value, Price and Cost
2 participants
@stap-m @l-emele